Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fqdn to SANs #40

Merged
merged 2 commits into from
Jul 29, 2019
Merged

added fqdn to SANs #40

merged 2 commits into from
Jul 29, 2019

Conversation

drewboswell
Copy link
Contributor

as per comment in slack by tvansteenburgh

hyperbolic2346
hyperbolic2346 approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR.

@hyperbolic2346 hyperbolic2346 merged commit 5ce21f5 into charmed-kubernetes:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewboswell @hyperbolic2346