Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support from focal to noble #359

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Adding support from focal to noble #359

merged 1 commit into from
Jul 26, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Jul 12, 2024

Overview

To support running on noble and jammy while still building/running on focal update python charm libaries

Details

  • Update metadata to support noble by moving metadata to charmcraft.yaml

@addyess
Copy link
Member Author

addyess commented Jul 12, 2024 •
edited
Loading

Waiting on an answer regarding changing the assumes in charmcraft.yaml

mateoflorido
mateoflorido approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@addyess addyess marked this pull request as ready for review July 26, 2024 17:30
@addyess addyess merged commit 151bee0 into main Jul 26, 2024
7 checks passed
@addyess addyess deleted the akd/noble-support branch July 26, 2024 17:30
@addyess addyess restored the akd/noble-support branch July 29, 2024 16:15
@addyess addyess mentioned this pull request Jul 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @mateoflorido