Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid dict merge in python3.8 #355

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

addyess
Copy link
Member

@addyess addyess commented Jun 20, 2024

Cannot use the | to merge two dicts in python3.8 (focal). Adjusting to a syntax which works in py3.8 and beyond

LP: https://bugs.launchpad.net/charm-kubernetes-master/+bug/2048699

Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice find! +1 on this for py38 and beyond.

@kwmonroe kwmonroe merged commit d1cc64f into main Jun 20, 2024
7 checks passed
@kwmonroe kwmonroe deleted the bug/2048699/invalid-py38 branch June 20, 2024 13:05
addyess added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants