Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin config to 1.29/stable snaps and tests to 1.29/stable charms #319

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Pin config to 1.29/stable snaps and tests to 1.29/stable charms #319

merged 1 commit into from
Dec 14, 2023

Conversation

addyess
Copy link
Member

@addyess addyess commented Dec 13, 2023

Per release checklist

  • Expect integration tests to fail because 1.29/stable charms don't yet exist

@addyess addyess changed the base branch from main to release_1.29 December 13, 2023 22:47
@addyess addyess marked this pull request as ready for review December 13, 2023 22:48
mateoflorido
mateoflorido approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateoflorido mateoflorido merged commit 13fb7c9 into release_1.29 Dec 14, 2023
6 of 7 checks passed
@mateoflorido mateoflorido deleted the akd/pin-stable-release branch December 14, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @mateoflorido