Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide support for the external-cloud-provider relation #307

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

addyess
Copy link
Member

@addyess addyess commented Oct 27, 2023

do not merge until charmed-kubernetes/charm-lib-kubernetes-snaps#7 is merged in

@addyess addyess marked this pull request as draft October 27, 2023 15:40
requirements.txt Outdated Show resolved Hide resolved
@addyess addyess marked this pull request as ready for review October 27, 2023 20:21
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mateoflorido mateoflorido merged commit bbdc6a1 into ops Oct 30, 2023
7 checks passed
@mateoflorido mateoflorido deleted the feature/cloud-integration branch October 30, 2023 12:05
@Cynerva
Copy link
Contributor

Cynerva commented Oct 30, 2023

👍 Nice, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants