Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement COS integration #306

Merged
merged 11 commits into from
Oct 30, 2023
Merged

Implement COS integration #306

merged 11 commits into from
Oct 30, 2023

Conversation

mateoflorido
Copy link
Member

Summary

This pull request introduces COS integration for the Kubernetes Control Plane charm.

Changes

  • Added the cos_agent interface library.
  • Added the tokens interface library.
  • Introduced update scripts for both AlertManager rules and Grafana Dashboards.
  • Integrated Grafana dashboards from the upstream source.
  • Integrated AlertManager rules from the upstream source.
  • Created Kubernetes ClusterRole and ClusterRoleBinding granting permissions to the metrics endpoints.
  • Set up the tox environment to run the update scripts.

Notes

  • Currently, it's not feasible to test both charms simultaneously due to pending integrations within the charm, such as cloud integration.

@mateoflorido mateoflorido marked this pull request as draft October 18, 2023 13:02
@mateoflorido mateoflorido marked this pull request as ready for review October 24, 2023 00:01
addyess
addyess requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check out the comment pertaining to get_node_name()

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
addyess
addyess approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit a87ab7e into ops Oct 30, 2023
7 checks passed
@addyess addyess deleted the m/observability branch October 30, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyess addyess addyess approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateoflorido @addyess