Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement kube-control and loadbalancer relations #304

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Implement kube-control and loadbalancer relations #304

merged 5 commits into from
Sep 26, 2023

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented Sep 22, 2023

Depends on juju-solutions/interface-kube-control#40

Adds the kube-control, loadbalancer-external and loadbalancer-internal relations, along with the loadbalancer-ips config option.

This is ready for review, but marked as draft until requirements.txt has been updated after the interface-kube-control PR lands.

mateoflorido
mateoflorido approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I really like the api_dependencies_ready refactor!

@Cynerva Cynerva marked this pull request as ready for review September 26, 2023 15:40
@Cynerva Cynerva merged commit 615bf63 into ops Sep 26, 2023
7 checks passed
@Cynerva Cynerva deleted the gkk/kube-control-loadbalancer branch September 26, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cynerva @mateoflorido