This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
chore: fix CI pipeline #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucciTheBoss
suggested changes
Jul 16, 2024
There was a problem hiding this comment.
Bug fix looks good. Nice catch!
Same comment as on your similar pull request against slurmd operator, I still think we should have a non-gating check against the edge branch in Charmhub. We can keep our discussion our discussion to the slurmd pull request, but we should have the same changes reflected here as well.
A fix was applied because there was a bug on the way we deferred `_on_slurmctld_available`.
jedel1043
force-pushed
the
fix-ci-pipeline
branch
from
05ce92c
to
2929cd1
Compare
NucciTheBoss
approved these changes
Jul 17, 2024
|
Since this pull request is similar to the fix CI pull request against slurmd, I'm going to go ahead and merge this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the CI pipeline so that we're testing our changes again.
Also, a fix was applied because there was a bug on the way we deferred
_on_slurmctld_available.How was the code tested?
Locally on my Ubuntu Jammy development setup.
Checklist