This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Add support for using local charms in integration tests #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed old references to ETCD. * Deleted helpers module because it was no longer necessary. * Add `--use-local` option to direct integration tests to use local slurmctld operator. Signed-off-by: Jason C. Nucciarone <[email protected]>
* Needed to replace type(...) == type calls with isinstance(...)
Using type(...) == type instead of isinstance violates lint rule E721.
Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
enable-local-testing
branch
from
5bb97b0
to
2fe34c6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to charmed-hpc/slurmctld-operator#17, but slurmdbd focused 😃
How was the code tested?
Integration tests were run on my Ubuntu 23.04 laptop.
Related issues and/or tasks
Closes #17
Checklist