This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Auto-generate version file when slurmdbd operator is packed #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the version file generation job step from the release workflow, removes the version file generation utilities from the integration tests, and modifies charmcraft.yaml so that the version file will be automatically generated when the slurmdbd charm is packed. Signed-off-by: Jason C. Nucciarone <[email protected]>
Unused imports left in helpers.py in integration tests. Signed-off-by: NucciTheBoss <[email protected]>
Merged
4 tasks
jaimesouza
approved these changes
Aug 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request modifies charmcraft.yaml so that the version file is automatically generated when packing the slurmdbd operator with
charmcraft pack ...How was the code tested?
Tested locally on my Ubuntu 22.04 LTS workstation by packing the slurmdbd charm and then examining the archive to ensure that the version file was successfully generated. The integration tests will likely fail for the time being due to issues identified in #15
Related issues and/or tasks
See Ubuntu HPC Matrix charming discussion
Checklist