Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slurmctld): add sane defaults for cgroup.conf #32

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jamesbeedy
Copy link
Contributor

These changes add reasonable defaults for charm cgroup.conf.

Fixes #31

These changes add reasonable defaults for charm cgroup.conf.
@NucciTheBoss NucciTheBoss added the bug Something isn't working label Oct 8, 2024
@NucciTheBoss NucciTheBoss self-requested a review October 8, 2024 17:26
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔍

Thank you for updating this default @jamesbeedy

@NucciTheBoss NucciTheBoss merged commit cc8ac43 into charmed-hpc:main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use sane defaults for cgroup.conf
2 participants