feat(enhancement): upgrade the ulimit configuration #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes enable 1048576 openfiles for processes spawned via slurmscriptd.
jamesbeedy
changed the title
|
Going to land #40 soon so I can look at this. @jamesbeedy are you able to verify that the correct openfile limit is being applied using the test you mentioned in #41? |
|
@NucciTheBoss awesome. yes, verified. |
|
Great! I'm doing some work to address charmed-hpc/slurm-charms#30 on the Slurm charms, so is it cool if I apply your patches there? We can also add onto our integration test suite to verify the the correct ulimit config is being applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable 1048576 openfiles for processes spawned via slurmscriptd.
Fixes #41