feat: option to disable external editor in Text field #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Jan 28, 2025
|
hey! thanks for the PR! would you mind adding a test for it as well? |
|
Yes, I can do that 👍🏽 |
|
I added a test and squashed the commits. |
caarlos0
reviewed
Jan 28, 2025
huh_test.go
Outdated
Comment on lines
392
to
395
| if !strings.Contains(view, "alt+enter / ctrl+j new line • enter submit") { | ||
| t.Log(pretty.Render(view)) | ||
| t.Error("Expected field to contain help, without ctrl+e.") | ||
| } |
There was a problem hiding this comment.
probably safer to check that view doesn't not contain 'ctrl+e'?
There was a problem hiding this comment.
I was trying to mirror the other text field test, but I agree with you. I updated it.
jonas-grgt
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to disable the external editor option in text fields. I was looking for this feature when I noticed that someone else had asked for the same thing in issue #512