Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make all setting false by default #677

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

andreynering
Copy link
Member

Closes #669

@andreynering andreynering added the bug Something isn't working label Feb 3, 2025
@andreynering andreynering self-assigned this Feb 3, 2025
@andreynering andreynering requested a review from a team as a code owner February 3, 2025 18:26
@andreynering andreynering requested review from raphamorim and bashbunni and removed request for a team February 3, 2025 18:26
@caarlos0
Copy link
Member

caarlos0 commented Feb 3, 2025

yeah, I agree that false should probably be the default, as it will follow gitignore by default.

users that want to see all files can still do so by changing settings or glow --all (which I think we might need to better document).

all in all im fine with this :)

@bashbunni
Copy link
Member

Since this is a breaking change for users, should we consider this for a next major version or some v0 release? I know we did v1 for glow already

@andreynering
Copy link
Member Author

@bashbunni Regarding being a breaking-change, it seems to be only partially breaking to me, because for users that already had the configuration file generated on their machine (on the first run), that setting won't be changed automatically. It'll only have the new default on new machines.

No strong opinion, though. I think I vote to merge now, but it's fine to wait if needed.

@bashbunni
Copy link
Member

@andreynering ah that makes sense, sounds good to me then :)

@andreynering andreynering merged commit 2671509 into master Feb 7, 2025
20 of 22 checks passed
@andreynering andreynering deleted the make-all-setting-false-by-default branch February 7, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

respect .gitignore
5 participants