Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: cleanup and updated #619

Merged
merged 4 commits into from
Jul 3, 2024
Merged

feat!: cleanup and updated #619

merged 4 commits into from
Jul 3, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 1, 2024

  • remove all the networking stuff (stashing, news)
  • update deps
  • update go
  • other misc improvements

@caarlos0
feat!: cleanup
0460fab 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
more cleanup
ee6f1f3 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0
fix: more cleanup
e7ae7bd 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 requested review from maaslalani and removed request for muesli July 1, 2024 18:40
@meowgorithm
Copy link
Member

Noticing a few things that need to be pulled in the pager portion:

  • Filename at the bottom should contain the full path and extension
  • The little green dot by the filename should go (formerly indicated a stashed document)
  • m set memo in the help should go

@caarlos0
Copy link
Member Author

caarlos0 commented Jul 2, 2024

done @meowgorithm

@meowgorithm
Copy link
Member

Looking good!

@meowgorithm meowgorithm mentioned this pull request Jul 3, 2024
Closed
@caarlos0
Copy link
Member Author

caarlos0 commented Jul 3, 2024

should we merge this to main, and start cleaning up issues/prs?

@meowgorithm
Copy link
Member

Let's do it!

@caarlos0 caarlos0 merged commit fce3edf into master Jul 3, 2024
16 checks passed
@caarlos0 caarlos0 deleted the cleanup branch July 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm

@maaslalani maaslalani Awaiting requested review from maaslalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @meowgorithm