Charge Control C: move list of supported peripherals into own list #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhei
changed the title
barsnick
requested changes
Mar 28, 2025
docs/source/hardware.rst
Outdated
| .. note:: | ||
| The Charge Control C boards use a Qualcomm Atheros QCA700x chip for Green PHY communication on CP line. | ||
| The shipped QCA700x firmware configuration contains a default set of prescalers which influence the | ||
| CP signal level (,,loudness”). |
There was a problem hiding this comment.
The ,, quotation marks still render as two commas. I'm not sure that's intended.
| Since Charge Control C can be freely programmed, it is possible that customers add additional device | ||
| support on their own, either by writing a customer EVerest module or adapting a model for GenericPowermeter. | ||
|
|
||
| The following table documents the default communication parameters for supported Modbus peripherals. |
There was a problem hiding this comment.
With this PR, we now no longer document the defaults. This is probably okay, so just a note that this is a change.
There was a problem hiding this comment.
The default stuff was copied over from Truffle but it does not fit EVerest at all. In Truffle we depending on the meter type different presets, but in EVerest you have to configure it directly.
FaHaGit
approved these changes
Mar 31, 2025
Signed-off-by: Michael Heimpold <[email protected]>
Get rid of the nasty "documentation" suffix in rendered HTML titles. Signed-off-by: Michael Heimpold <[email protected]>
Signed-off-by: Michael Heimpold <[email protected]>
lategoodbye
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR can only be merged as-is if #44 is merged via fast-forward.