Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal error when assigning a type to a value #26517

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix internal error when assigning a type to a value #26517

merged 3 commits into from
Jan 14, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Jan 14, 2025 •
edited
Loading

Fixes an internal error when trying to assign a type to a value inside a task intent.

Resolves #26511

  • full paratest with/without gasnet

[Reviewed by @mppf]

@jabraham17
prevent segfault
ecb50b3 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
add test
547d7d2 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 marked this pull request as ready for review January 14, 2025 00:32
@jabraham17 jabraham17 requested a review from mppf January 14, 2025 01:15
mppf
mppf approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@mppf mppf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

compiler/resolution/functionResolution.cpp Outdated Show resolved Hide resolved
@jabraham17
move fn def out of if stmt
07e320d 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 merged commit a4397d5 into chapel-lang:main Jan 14, 2025
8 checks passed
@jabraham17 jabraham17 deleted the fix-internal-error-intents branch January 14, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mppf mppf mppf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: missing 'new' in a loop intent causes internal error
2 participants
@jabraham17 @mppf