Log two new first class procedure tests #26214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are based off of chapel-lang#18413, though updated for the new syntax for FCPs. Unfortunately, the new syntax has caused the second test (which was a workaround for the first) to also not work, so both are being logged as futures. ---- Signed-off-by: Lydia Duncan <[email protected]>
This was referenced Nov 5, 2024
…te tests `proc (` is not supported due to parser conflicts, only `proc(`. Updated the tests with that in mind. The assignInIfExpr test still encountered a syntax error, so update the .bad file, and point the .future file at the original issue. The assignLater test also needed to update the syntax declaring the type of the variable, but after that the test worked like the original version did at the time it was created, so removed the .bad and .future file. ---- Signed-off-by: Lydia Duncan <[email protected]>
lydia-duncan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are based off of #18413, though updated for the new syntax for FCPs (based on the deprecation warnings I encountered when trying to compile them).
A fresh checkout of the tests behaved as expected