Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving 'this' call on shadowing variable #25954

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Fix resolving 'this' call on shadowing variable #25954

merged 11 commits into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. Add test for correct ambiguity between procs 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5f77529 View commit details
    Browse the repository at this point in the history

  2. Add test for resolving 'this' on shadowing var 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2fa73a2 View commit details
    Browse the repository at this point in the history

  3. Repeat lookupIdentifier as non-called if no methods found 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d1207dc View commit details
    Browse the repository at this point in the history

  4. Only repeat lookupIdentifier when result is ambiguous 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    553310a View commit details
    Browse the repository at this point in the history

  5. Clarify comment and var name 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    813dd30 View commit details
    Browse the repository at this point in the history

  6. Check for any procs, not just methods 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    78dc920 View commit details
    Browse the repository at this point in the history

  7. Resolve to innermost identifier for called var case 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    36404d6 View commit details
    Browse the repository at this point in the history

  8. Check for vars only rather than absence of functions 

    To avoid edge cases with module names

Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dc6311e View commit details
    Browse the repository at this point in the history

  9. Remove redundant calculation of resolvingCalledIdent 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cc1d0d0 View commit details
    Browse the repository at this point in the history

  10. Add TODO for a more principled solution 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    497bb7d View commit details
    Browse the repository at this point in the history

  11. Test and handle similar shadowing formal case 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    775be43 View commit details
    Browse the repository at this point in the history