add various GPU device query functions #25945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Andy Stone <[email protected]>
stonea
changed the title
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
e-kayrakli
approved these changes
Oct 15, 2024
runtime/src/gpu/amd/gpu-amd.c
Outdated
| @@ -512,5 +512,60 @@ void chpl_gpu_impl_host_unregister(void* var) { | |||
| ROCM_CALL(hipHostUnregister(var)); | |||
| } | |||
|
|
|||
| void chpl_gpu_impl_name(int dev, char **result) { | |||
| char* name = (char *)chpl_mem_alloc(0xFF, CHPL_RT_MD_IO_BUFFER, __LINE__, 0); | |||
There was a problem hiding this comment.
I have a preference towards doing this allocation in chpl-gpu.c as I don't see this as a vendor-specific operation.
There was a problem hiding this comment.
Why 0xFF for size?
I need to have some cap on the size and that seems like a nice, round, number that won't waste too much memory but will be large enough to store any reasonable device name.
I've factored out the (non GPU-vendor specific) allocation into chpl-gpu.c.
|
Also, don't forget to remove "draft" from the PR message. :) |
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
DeviceAttributestype that includes a number of parenless proc functions to query various attributes about the GPU. (for example: max threads per block, device name, etc.)This aims to resolve #23638