Only repeat lookupIdentifier when result is ambiguous

Signed-off-by: Anna Rift <[email protected]>
chapel-lang · Sep 17, 2024 · b23a3c8 · b23a3c8
1 parent 9768d57
commit b23a3c8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/frontend/lib/resolution/Resolver.cpp b/frontend/lib/resolution/Resolver.cpp
@@ -2996,10 +2996,10 @@ void Resolver::resolveIdentifier(const Identifier* ident) {
   auto parenlessInfo = ParenlessOverloadInfo();
   auto ids = lookupIdentifier(ident, resolvingCalledIdent, parenlessInfo);
 
-  // If we looked up a called identifier and got no method results,
-  // repeat lookup for the identifier as though it wasn't called, to support
-  // implicit 'this' calls.
-  if (resolvingCalledIdent && !ids.isEmpty()) {
+  // If we looked up a called identifier and found ambiguity but no method
+  // results, repeat lookup for the identifier as though it wasn't called, to
+  // support implicit 'this' calls.
+  if (resolvingCalledIdent && ids.numIds() > 1) {
     bool anyMethod = false;
     for (auto idIt = ids.begin(); idIt != ids.end(); ++idIt) {
       if (idIt.curIdAndFlags().isMethod()) {