Skip to content

Commit

Permalink
Fixup docs and comments after removal of assertOnFailToGpuize (#26492)
Browse files Browse the repository at this point in the history
That test specifically made use of the old, functional form of
`assertOnGpu`, and was deleted when that form was removed. However, a
couple of comments and the tech note still referenced it. Fix that.

Reviewed by @stonea -- thanks!
  • Loading branch information
DanilaFe authored Jan 13, 2025
2 parents b3ad8fc + 0354a95 commit 0ef7752
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion doc/rst/technotes/gpu.rst
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Benchmark examples

Test examples
~~~~~~~~~~~~~
* `assertOnFailToGpuize <https://github.com/chapel-lang/chapel/blob/main/test/gpu/native/assertOnFailToGpuize.chpl>`_ -- various examples of loops that are not eligible for GPU execution
* `assertOnFailToGpuizeAttr <https://github.com/chapel-lang/chapel/blob/main/test/gpu/native/assertOnFailToGpuizeAttr.chpl>`_ -- various examples of loops that are not eligible for GPU execution
* `mathOps <https://github.com/chapel-lang/chapel/blob/main/test/gpu/native/mathOps.chpl>`_ -- calls to various math functions within kernels that call out to the CUDA Math library
* `measureGpuCycles <https://github.com/chapel-lang/chapel/blob/main/test/gpu/native/measureGpuCycles.chpl>`_ -- measuring time within a GPU kernel
* `promotion2 <https://github.com/chapel-lang/chapel/blob/main/test/gpu/native/promotion2.chpl>`_ -- GPU kernels from promoted expressions
Expand Down
4 changes: 0 additions & 4 deletions test/gpu/native/assertOnFailToGpuizeAttr.chpl
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
// This test and assertOnFailToGpuize are siblings; they both test the
// same functionality, one as an attribute (this one) and one as
// a "magic function call" (the other one).

use GPU;

config param failureMode = 8;
Expand Down
2 changes: 1 addition & 1 deletion test/gpu/native/assertOnNotGpuEligible.chpl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This test and assertOnFailToGpuize are siblings; this one tests
// This test and assertOnFailToGpuizeAttr are siblings; this one tests
// @gpu.assertEligible, which does not have a runtime component.

use GPU;
Expand Down

0 comments on commit 0ef7752

Please sign in to comment.