[git] Fix file stats for merged files on subdirs #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats about changes on a file were not reported correctly for files that where moved to a subdirectory. They were reported as an invalid entry and without action associated. For example, the file `dir/filename` was moved to `dir/subdir/filename`, but it was reported as `dir//filename`. Therefore, the entry of the file `dir/subdire/filename` didn't have the stats about added and deleted lines. This error has been fixed and stats are reported correctly. Signed-off-by: Santiago Dueñas <[email protected]>
sduenas
force-pushed
the
fix_git_rename_oldpath
branch
4 times, most recently
from
95ff439
to
46e9705
Compare
This commit tries to fix the problems we have with coveralls. It fails and the tests don't pass on GitHub Actions. Signed-off-by: Santiago Dueñas <[email protected]>
sduenas
force-pushed
the
fix_git_rename_oldpath
branch
from
46e9705
to
c8acf7f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats about changes on a file were not reported correctly for files that where moved to a subdirectory. They were reported as an invalid entry and without action associated.
For example, the file
dir/filenamewas moved todir/subdir/filename, but it was reported asdir//filename. Therefore, the entry of the filedir/subdire/filenamedidn't have the stats about added and deleted lines. This error has been fixed and stats are reported correctly.