Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Debian 11 #176

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update to Debian 11 #176

wants to merge 7 commits into from

Conversation

Gapstare
Copy link

Update to use Debian 11 to build with Vagrant. This breaks modplay functionality.

Vagrantfile Outdated
echo deb http://httpredir.debian.org/debian/ bullseye main > /etc/apt/sources.list
echo deb-src http://httpredir.debian.org/debian/ bullseye main >> /etc/apt/sources.list
# echo deb http://security.debian.org/debian-security bullseye/updates main >> /etc/apt/sources.list
# echo deb-src http://security.debian.org/debian-security bullseye/updates main >> /etc/apt/sources.list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason the security updates are commented out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not really, I guess I just didn't think I needed them for just building this. I'll enable them again, probably a good thing to have.

@@ -29,13 +31,15 @@ Vagrant.configure(2) do |config|
nasm \
psmisc \
qemu \
gcc-arm-none-eabi \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... Are you running this on an M1/M2/M3-based Mac perhaps? Or some other ARM-based machine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ah, was already present elsewhere from before.. 🙂)

Vagrantfile Outdated
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y gcc-arm-none-eabi
#echo deb http://httpredir.debian.org/debian/ unstable main >> /etc/apt/sources.list
#sudo apt-get update
#sudo DEBIAN_FRONTEND=noninteractive apt-get install -y gcc-arm-none-eabi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can remove both the commented out code and the comment before? Since the package is now available (in newer Debian versions).

@perlun
Copy link
Contributor

perlun commented Sep 25, 2024

Looks good @Gapstare, thanks for the effort! 🌟 I gave some initial feedback now. I think we can merge this once we've addressed these points. We'll have to live with the modplay not being compilable as-is for now.

@Gapstare
Copy link
Author

Gapstare commented Oct 3, 2024

Ok, how about now? 🙂

@Gapstare Gapstare requested a review from perlun October 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants