build: add make deb target for debian package #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the lack of packaging makes testing the installed diod messy on the test system. Add a 'make deb' target to build snapshot packages in debbuild, borrowing heavily from Mark Grondona's work in flux-framework.
Problem: compilation of diodls.c fails due to a potential string
overflow when building a test deb.
In function ‘snprintf’,
inlined from ‘np_deserialize_p9dirent’ at ../libnpfs/np.c:1712:3,
inlined from ‘npc_readdir_r’ at ../libnpclient/readdir.c:115:8,
inlined from ‘lsdir’ at diodls.c:240:14:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:10: error: ‘__builtin___snprintf_chk’ specified bound 4097 exceeds destination size 256 [-Werror=stringop-overflow=]
71 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ^
lto1: all warnings being treated as errors
Add an explicit check for the overflow and use memcpy() instead of
snprintf("%.*s") here.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the lack of packaging makes testing the installed
diodmessy on the test system.Add a 'make deb' target to build snapshot packages in
debbuild, borrowing heavily from @grondo's work in flux-framework.This is currently based on top of #114