Skip to content

Commit

Permalink
build: drop configure --disable-tests option
Browse files Browse the repository at this point in the history
Problem: configure --disable-tests doesn't accomplish anything.

Running 'make check' and getting a positive outcome when nothing
was run is misleading.  The right thing to do is to skip individual
tests when features are de-selected.

For now just remove this configure option.
  • Loading branch information
garlick committed Jan 17, 2025
1 parent 1a9391d commit 2a97ff6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 27 deletions.
4 changes: 0 additions & 4 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ SUBDIRS = \
man \
etc

if ENABLE_TESTS
SUBDIRS += tests
endif

EXTRA_DIST = diod.spec

export DEB_BUILD_OPTIONS ?= nocheck terse
Expand Down
23 changes: 0 additions & 23 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ AC_ARG_ENABLE([diodmount],
[AS_HELP_STRING([--disable-diodmount], [do not build diodmount])],
[],
[enable_diodmount=auto])
AC_ARG_ENABLE([tests],
[AS_HELP_STRING([--disable-tests], [do not build tests])],
[],
[enable_tests=auto])
AC_ARG_ENABLE([impersonation],
[AS_HELP_STRING([--enable-impersonation], [allow access=user])],
[],
Expand Down Expand Up @@ -127,12 +123,6 @@ case "${host_os}" in
*)
enable_diodmount=yes;;
esac
case "${enable_tests}" in
no)
;;
*)
enable_tests=yes;;
esac
case "${enable_impersonation}" in
no)
;;
Expand All @@ -149,12 +139,6 @@ case "${host_os}" in
*)
enable_diodmount=no;;
esac
case "${enable_tests}" in
yes)
;;
*)
enable_tests=no;;
esac
case "${enable_impersonation}" in
no|auto)
enable_impersonation=no;;
Expand All @@ -171,12 +155,6 @@ case "${host_os}" in
*)
enable_diodmount=no;;
esac
case "${enable_tests}" in
yes)
;;
*)
enable_tests=no;;
esac
case "${enable_impersonation}" in
no|auto)
enable_impersonation=no;;
Expand All @@ -187,7 +165,6 @@ case "${host_os}" in
esac

AM_CONDITIONAL([ENABLE_DIODMOUNT], [test "x${enable_diodmount}" = "xyes"])
AM_CONDITIONAL([ENABLE_TESTS], [test "x${enable_tests}" = "xyes"])
AM_CONDITIONAL([USE_IMPERSONATION_LINUX], [test "x${enable_impersonation}" = "xlinux"])
AM_CONDITIONAL([USE_IMPERSONATION_GANESHA], [test "x${enable_impersonation}" = "xganesha"])

Expand Down

0 comments on commit 2a97ff6

Please sign in to comment.