Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move continuous fields to the dataset drawer if there is a single value for all cells #918

Merged
merged 9 commits into from
May 10, 2024

Conversation

seve
Copy link
Contributor

@seve seve commented May 8, 2024

#615

Adds redux state and handling logic in histogram component to remove fields if the anno matrix is not a view and the field contains a single value for all obs.

To test:

copy the test dataset to example-dataset/:

AWS_PROFILE=single-cell-prod aws s3 cp --recursive s3://hosted-cellxgene-prod/67a79be6-e85f-471b-82cf-1d773f61f8f2.cxg ./singleton.cxg/

navigate to the dataset

you should not see donor_BMI_at_collection in the LSB, but rather the dataset drawer

@seve seve requested review from tihuan and atarashansky May 8, 2024 22:26
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (0d204de) to head (04b7577).
Report is 38 commits behind head on main.

❗ Current head 04b7577 differs from pull request most recent head 4d876b3. Consider uploading reports for the commit 4d876b3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   77.47%   77.27%   -0.21%     
==========================================
  Files          88       90       +2     
  Lines        6856     7024     +168     
==========================================
+ Hits         5312     5428     +116     
- Misses       1544     1596      +52     
Flag Coverage Δ
frontend 77.27% <ø> (-0.21%) ⬇️
javascript 77.27% <ø> (-0.21%) ⬇️
smokeTest ?
unitTest 77.27% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atarashansky atarashansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much work would it be to add a test for this? Could we write a singleton continuous field to the obs metadata for pbcm3k.cxg?

client/src/components/brushableHistogram/index.tsx Outdated Show resolved Hide resolved
client/src/components/brushableHistogram/index.tsx Outdated Show resolved Hide resolved
client/src/reducers/singleContinuousValue.ts Outdated Show resolved Hide resolved
@seve seve requested a review from atarashansky May 10, 2024 17:48
@seve
Copy link
Contributor Author

seve commented May 10, 2024

#872

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but please wait for Alec's review on business logics, since I feel that I don't have enough context to form an opinion there 😆 🙏

Thank you!

@seve seve enabled auto-merge (squash) May 10, 2024 18:48
@seve seve merged commit 055b24d into main May 10, 2024
4 of 5 checks passed
@seve seve deleted the seve/single-continuous branch May 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2Q2024] Single continuous variable values should show up in the dataset drawer
3 participants