Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cellguide): Add slack notification to pipeline and skip if DOI returns 404 #7359

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Oct 9, 2024

Reason for Change

Changes

  • Added slack notification to pipeline in case of success/fail
  • Revised _fetch_crossref_payload to return None in case of 404 instead of raising
  • Updated relevant unit test

Testing steps

  • Unit tests
  • Run pipeline in staging

TODO: address "doesn't create a collection with an invalid DOI" logged in test that is now failing as result of not raising on bad DOI

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Deployment Summary

@kaloster kaloster changed the title chore: add slack notify chore(cellguide): Add slack notification to pipeline and skip if DOI returns 404 Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (0f6646b) to head (f968ffe).

Files with missing lines Patch % Lines
backend/common/utils/result_notification.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7359      +/-   ##
==========================================
- Coverage   92.91%   92.90%   -0.01%     
==========================================
  Files         194      194              
  Lines       16827    16832       +5     
==========================================
+ Hits        15635    15638       +3     
- Misses       1192     1194       +2     
Flag Coverage Δ
unittests 92.90% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster marked this pull request as ready for review October 9, 2024 16:21
@kaloster kaloster marked this pull request as draft October 10, 2024 21:08
@atarashansky atarashansky marked this pull request as ready for review October 12, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants