Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changes to add uns metadata for spatial #6658

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Feb 13, 2024

Reason for Change

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

Copy link
Contributor

Deployment Summary

@kaloster kaloster marked this pull request as draft February 13, 2024 19:03
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 92.22%. Comparing base (d67f92f) to head (b68d916).
Report is 73 commits behind head on main.

Files Patch % Lines
backend/common/utils/cxg_generation_utils.py 50.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6658      +/-   ##
==========================================
+ Coverage   92.20%   92.22%   +0.02%     
==========================================
  Files         180      182       +2     
  Lines       15027    15214     +187     
==========================================
+ Hits        13855    14031     +176     
- Misses       1172     1183      +11     
Flag Coverage Δ
unittests 92.22% <54.54%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant