-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperate sorbet sigs from rb files #80
base: master
Are you sure you want to change the base?
Conversation
da95172
to
b83fe2d
Compare
You can |
Actually, I think we're moving way from sorbet-runtime completely; and only use sorbet for static tc |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 96.95% 96.97% +0.01%
==========================================
Files 35 35
Lines 1743 1553 -190
==========================================
- Hits 1690 1506 -184
+ Misses 53 47 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Note - to deal with the merge conflicts, I went through each merge file and moved |
Hey @donaldong, just wanted to ask - what was the original purpose of this PR / how should I continue it, if at all? Katy and I were considering also completely removing sorbet from the project. Alternatively, I can port over the original remove-sig logic to the new code that were introduced to
|
This separates the sorbet sigs from rb files so sorbet runtime won't affect the lib code.
Test Plan