Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic type checking and linting via pre-commit #49

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

jgadling
Copy link
Contributor

@jgadling jgadling commented Jun 7, 2024

This is a very early attempt to enable standard linting for consistency in line length, variable names, and annotations.
I've also updated this repo to use a consistent version of python across all of our containers and packages and tests.

I've had to add in a few workarounds for some code that was nowhere near passing lint and type checking:

  • Right now untyped function definitions are allowed. This is really bad! However there are hundreds of functions that need annotating. We can update them piecemeal.
  • I've added a few #noqa comments on lines that are either low-priority or extremely difficult to fix.
  • the code in platformics/api/relay and platformics/thirdparty was very far away from being able to be type-checked well, so those are ignored in our mypy configurations at the moment.

@jgadling jgadling merged commit d1fe013 into main Jun 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants