Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests to pass #34

Merged
merged 17 commits into from
Jun 18, 2024
Merged

Get tests to pass #34

merged 17 commits into from
Jun 18, 2024

Conversation

valenzuelaomar
Copy link
Collaborator

@valenzuelaomar valenzuelaomar commented Jun 5, 2024

Description

Pull in tests from czid-platformics and gets most working

Before this PR, we had 16 tests pass / 13 fail. After this PR gets merged in, we will have 60 pass / 21 fail.

The 21 test failures have been created as issues

Remaining failures

FAILED tests/test_authorization.py::test_system_fields_only_mutable_by_system - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_authorization.py::test_system_types_only_mutable_by_system - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_authorization.py::test_create_wont_associate_inaccessible_relationships - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_cascade_deletion.py::test_cascade_delete - assert 1 == 0
FAILED tests/test_error_handling.py::test_python_error - assert 'Unexpected error' in "Cannot query field 'uncaughtException' on type 'Query'."
FAILED tests/test_field_visibility.py::test_hidden_mutations - AssertionError: assert 'createImmutableType' in ['createFile', 'uploadFile', 'uploadTemporaryFile', 'markUploadComplete', 'concatenateFiles', 'createSample', ...]
FAILED tests/test_field_visibility.py::test_update_fields - AssertionError: assert {'collectionI...ngRunId', ...} == {'clearlabsEx... 'technology'}
FAILED tests/test_field_visibility.py::test_creation_fields - AssertionError: assert {'collectionI...oducingRunId'} == {'collectionI...oducingRunId'}
FAILED tests/test_file_concatenation.py::test_concatenation[test1.fasta-test2.fasta] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_concatenation.py::test_concatenation[test1.fasta.gz-test2.fasta.gz] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_mutations.py::test_upload_file[member_projects2-123-r1_file] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_mutations.py::test_create_file - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_mutations.py::test_delete_from_s3[nextgen/test1.fastq-False-True] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_mutations.py::test_delete_from_s3[bla/test1.fastq-False-False] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_mutations.py::test_delete_from_s3[nextgen/test1.fastq-True-False] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_mutations.py::test_delete_from_s3[bla/test1.fastq-True-False] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_queries.py::test_file_query - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_uploads.py::test_upload_process - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_file_uploads.py::test_upload_process_multiple_files_per_entity - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_nested_queries.py::test_relay_node_queries - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_where_clause.py::test_soft_deleted_objects - TypeError: 'NoneType' object is not subscriptable

@valenzuelaomar valenzuelaomar changed the title [valenzuelaomar/get-tests-working] Get tests to pass Get tests to pass Jun 5, 2024

title = settings.SERVICE_NAME
graphql_app: GraphQLRouter = GraphQLRouter(schema, context_getter=get_context, graphiql=True)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphql_ide is set to graphiql by default

@valenzuelaomar valenzuelaomar marked this pull request as ready for review June 18, 2024 20:34
@valenzuelaomar valenzuelaomar merged commit 45277fc into main Jun 18, 2024
1 check failed
@valenzuelaomar valenzuelaomar deleted the valenzuelaomar/get-tests-working branch June 18, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants