Use GraphQL client instead of custom model and IO #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 88.10% 87.34% -0.77%
==========================================
Files 15 13 -2
Lines 639 553 -86
==========================================
- Hits 563 483 -80
+ Misses 76 70 -6
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jgadling
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the GraphQL client defined in the
cryoet-data-portalpackage related to this project. The main motivations for doing this are as follows.cryoet-data-portaland improve it.Listing the datasets and tomograms seems a little slower than using s3fs/fsspec, but the benefits are worth the cost.
This removes support for the local filesystem as a storage backend for the portal data because obviously the client does not support that. The code to support different URLs for the GraphQL entry point are kept, but we make the line-edit read-only in the GUI because only the default URL works and others cause problems.
This also removes mocks from some of the tests because mocking the client is trickier than mocking our own classes/functions. Tests take longer, but we adjusted the timeouts to account for that. That's good enough as a short term solution, but ultimately we need mocks/fakes to avoid long running tests.