Increase timeouts for tests that open and load data #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests run against the production API. Some of these have recently been failing by timing out when waiting to open/load tomograms and their annotations. This is occurring on
mainand I'd like to have the tests pass there before creating a new release to address a couple of unrelated bug fixes.This PR increases timeouts for from 30 to 60 seconds. This is a short term fix that I'm hoping will be good enough.
If we want to support this plugin and its tests in the long term, we should probably set up a fake API for the tests to run against. Or provide a way to filter which tomograms/annotations are opened/loaded and use that in the tests.