Only rescale points for older napari versions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napari v0.5 includes a fix to handle expected combinations of point size and layer scale. Previously, we worked around that issue by rescaling the point sizes ourselves. After this PR, we only do that for older versions of napari. The check is cached to avoid spamming the logs.
Alternatively, we could require
napari>=0.5insetup.cfg. I decided to support both versions for now, since v0.5 is quite new and comes with a few of its own new bugs.This was tested manually by installing v0.4.19 and v0.5.2 of napari and visually inspecting the resulting point sizes.