[WIP] Fix offset of images at lower resolutions due to non-unit scale #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-sweet
changed the title
andy-sweet
added a commit
that referenced
this pull request
May 21, 2024
This adds support for segmentation-mask and oriented-points annotations types.  Segmentation masks are supported by loading the corresponding OME-Zarrs in a similar way to the tomogram (i.e. according to resolution). Oriented points are currently read and displayed as regular points. We can follow up with another PR to augment that with the orientation information (e.g. with a vectors layer). As some datasets contain tomograms with lots of different annotations (e.g. 10000), performance can suffer both while waiting for data to arrive and when interacting with napari once it has. This also fixes an alignment issue caused by the highest resolution tomogram volume having a non-unit volume. I originally separated that into #31, but there was some overlap with the changes here, so I brought it into this PR. Closes #22 and #23
|
Closing in favor of #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the highest/raw resolution tomograms now have a non-unit scale, this caused a bug when visualizing the non-highest/raw resolution tomograms with points annotations due to the way in which we manually offset the tomograms for appropriate display in napari.
This fixes the offset so that it properly takes into account the scale of the tomograms.
Still a WIP, because I need to work out what to do about napari/napari#6914 here.