Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cryoet-data-portal client v3.0 #28

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

jgadling
Copy link
Contributor

There were some breaking changes in the latest release. I think this is all that needs to change to support the results from find() and 1:many relationships being converted from Iterable to list

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (966a523) 82.12% compared to head (899b201) 82.36%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/napari_cryoet_data_portal/_open_widget.py 0.00% 4 Missing ⚠️
src/napari_cryoet_data_portal/_reader.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   82.12%   82.36%   +0.24%     
==========================================
  Files          14       14              
  Lines         660      669       +9     
==========================================
+ Hits          542      551       +9     
  Misses        118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andy-sweet andy-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vaguely concerned about the performance implications of lists over iterators/generators, but I don't see any issues in practice and there are more serious performance problems to worry about.

Thanks for the updates!


tomogram: Tomogram = next(tomogram_spacing.tomograms)
tomogram: Tomogram = tomogram_spacing.tomograms.pop()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[0] would be equivalent, but I assume we only expect one element, so it doesn't really matter.

@andy-sweet andy-sweet merged commit e285545 into main Jan 31, 2024
10 of 11 checks passed
@andy-sweet andy-sweet deleted the jgadling/upgrade-3.0 branch January 31, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants