Basic filter by dataset and spacing IDs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-sweet
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 87.34% 82.01% -5.33%
==========================================
Files 13 14 +1
Lines 553 656 +103
==========================================
+ Hits 483 538 +55
- Misses 70 118 +48 ☔ View full report in Codecov by Sentry. |
anchi2c
reviewed
Nov 30, 2023
| self._filter_ids_type = QComboBox() | ||
| self._filter_ids_type.addItem("Dataset IDs", Dataset) | ||
| self._filter_ids_type.addItem("Run IDs", Run) | ||
| self._filter_ids_type.addItem("Spacing IDs", TomogramVoxelSpacing) |
There was a problem hiding this comment.
Can we at least call this VxlSpacing IDs ? The texting generation will read that ok. Spacing is not saying much.
There was a problem hiding this comment.
I originally had this as "Voxel Spacing IDs" and then compressed it to "Spacing IDs" for horizontal space saving, so I'm going to switch back to that.
anchi2c
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some widgets to the portal connection/URI sub-widget that allows users to search for a specific datasets and tomograms using known IDs.
It also add tests that use some of this filtering behavior as a way to exercise the behavior and to better bound test time against the real GraphQL backend.
Closes #12