Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Build amd64 images explicitly to avoid cross-platform issues #224

Closed
wants to merge 37 commits into from
Closed

feat: Build amd64 images explicitly to avoid cross-platform issues #224

wants to merge 37 commits into from

Conversation

alexlokshin-czi
Copy link
Contributor

Closes #204

@alexlokshin-czi alexlokshin-czi requested a review from a team as a code owner April 7, 2022 21:06
@alexlokshin-czi alexlokshin-czi requested a review from edulop91 April 7, 2022 21:06
@alexlokshin-czi alexlokshin-czi marked this pull request as draft April 7, 2022 21:06
alexlokshin-czi and others added 18 commits April 8, 2022 10:42
@alexlokshin-czi alexlokshin-czi marked this pull request as ready for review April 11, 2022 15:25
@alexlokshin-czi alexlokshin-czi enabled auto-merge (squash) April 11, 2022 17:27
edulop91
edulop91 reviewed Apr 11, 2022
View reviewed changes
pkg/artifact_builder/artifact_builder.go Outdated Show resolved Hide resolved
pkg/artifact_builder/docker_compose.go Outdated Show resolved Hide resolved
pkg/artifact_builder/docker_compose.go Outdated Show resolved Hide resolved
pkg/util/platform.go Show resolved Hide resolved
pkg/util/platform.go Show resolved Hide resolved
pkg/util/platform.go Outdated Show resolved Hide resolved
pkg/util/platform.go Outdated Show resolved Hide resolved
edulop91
edulop91 reviewed Apr 12, 2022
View reviewed changes
pkg/artifact_builder/artifact_builder.go Outdated Show resolved Hide resolved
pkg/artifact_builder/artifact_builder_test.go Outdated Show resolved Hide resolved
pkg/util/platform.go Show resolved Hide resolved
pkg/artifact_builder/docker_compose.go Show resolved Hide resolved
@edulop91
Copy link
Contributor

going to close this one for now since we put the warning instead

@edulop91 edulop91 closed this May 20, 2022
auto-merge was automatically disabled May 20, 2022 20:37

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edulop91 edulop91 edulop91 left review comments

@dtsai-czi dtsai-czi Awaiting requested review from dtsai-czi

Assignees

@alexlokshin-czi alexlokshin-czi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Build amd64 images explicitly to avoid cross-platform issues
2 participants
@alexlokshin-czi @edulop91