feat: Create databricks catalog ext loc modules #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alldoami
changed the title
jayengee
reviewed
Aug 14, 2024
jayengee
reviewed
Aug 14, 2024
jayengee
reviewed
Aug 14, 2024
jayengee
reviewed
Aug 14, 2024
alldoami
requested review from
jayengee
and removed request for
alexlokshin-czi
alldoami
commented
Aug 15, 2024
| } | ||
| databricks = { | ||
| source = "databricks/databricks" | ||
| version = "1.49.1" |
There was a problem hiding this comment.
required for the isolation_mode attribute for databricks_external_location
jayengee
requested changes
Aug 15, 2024
jayengee
approved these changes
Aug 16, 2024
alldoami
deleted the
CDI-3232-create-module-for-catalog-bucket-and-dbx-access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This creates a bucket for databricks catalogs to use. It sets up the iam permissions that allows databricks access to read/write to the bucket. In order to associate a databricks catalog to a S3 bucket, it needs a storage credential which is connected to an external location (which is the S3 bucket).
The
databricks-catalogmodule creates a new catalog associated to the bucket with the desired permissions.Test Plan
Tested modules in shared-infra. Will be removing from shared-infra after merging and releasing.