Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix subsample depth #379

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[Bugfix] Fix subsample depth #379

merged 2 commits into from
Oct 2, 2024

Conversation

rzlim08
Copy link
Collaborator

@rzlim08 rzlim08 commented Oct 1, 2024

  • reduce subsampling depth

vincent-czi
vincent-czi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@vincent-czi vincent-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code tweak seems reasonable. Might be nice to just comment in this PR a little more info of what was going on before, maybe reference the ticket if there was one? But code is certainly approved!

@rzlim08 rzlim08 merged commit a04293a into main Oct 2, 2024
11 checks passed
@rzlim08 rzlim08 deleted the rlim/fix-subsample-depth branch October 2, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-czi vincent-czi vincent-czi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzlim08 @vincent-czi