-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CZID-8461] Start happy setup #75
Conversation
workflows/docker-compose.yml
Outdated
@@ -1,18 +1,15 @@ | |||
version: '3.8' | |||
|
|||
x-aws-variables: &aws-variables | |||
? AWS_ACCESS_KEY_ID | |||
? AWS_SECRET_ACCESS_KEY | |||
? AWS_SESSION_TOKEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will trip up @rzlim08 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-x-han is there a reason to get rid of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch, I'll add them back in. I think the happy command I used to generate some of the files also modified the docker-compose files, I must have missed reverting this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the happy CLI freak out if these vars don't exist in your environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested it, seems to work fine even if those variables aren't defined
app_name = var.app | ||
deployment_stage = "dev" | ||
additional_env_vars = { | ||
CERBOS_URL = "http://cerbos.cerbos-system.svc.cluster.local:3592" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're going to need to add cerbos to our applications as a sidecar (see input var format here: https://github.com/chanzuckerberg/happy/blob/main/terraform/modules/happy-service-eks/variables.tf#L289) for our main applications, but we can add that in later.
Description
This PR begins the happy setup needed for cloud deployment; so far this has only been tested for the dev environment, but some of the config for staging has been started as well.
(Instructions on how to install happy) To start a stack, run
happy create <your-stack-name>
in the directory of the service you want to start. You should be able to see the service running at<your-stack-name>.dev.happy.czid.org/graphql
.Notes
There are still a few TODOs for everything to be functional:
happy migrate <stack-name>
doesn't seem to run the script as expected; however, I was able to manually run the script when executing into the container.public
schema (which results in conflicts since their migrations both create anentities
table).httpcore.ConnectError: [Errno -2] Name or service not known
. Looking at the stack trace, I suspect the issue is because cerbos isn't set up properly. Here's the relevant snippet: