[CZID-8655] Small fix for markUploadComplete mutation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertaboukhalil
changed the title
| @@ -68,14 +68,14 @@ async def mark_upload_complete( | |||
| else: | |||
| file.status = db.FileStatus.SUCCESS | |||
| file.size = file_size | |||
| await session.commit() | |||
There was a problem hiding this comment.
This is the main fix
There was a problem hiding this comment.
I think this should be handled by our session handler wrappers -- is this necessary?
There was a problem hiding this comment.
I'm not sure why, but when I call that mutation, it doesn't update the DB without that line. Could it that we need session.commit here or is that unrelated?
There was a problem hiding this comment.
ahhh yeah I think that's the better place for the commit
There was a problem hiding this comment.
Ok so I tried moving it there, but ran into 2 issues:
- It breaks this part of the code, where we need to commit to the DB to generate the UUID before returning it to the user, otherwise GQL complains with errors like
Cannot return null for non-nullable field Sample.id(since the ID was created after the return) - We could return a successful API response, but it's possible that saving to the database fails, in which case what we're returning is not accurate 🙁
What do you think about keeping the session.commit() after all?
There was a problem hiding this comment.
yeah, sounds like it needs more thought, we can come back to it later 👍
entities/database_migrations/versions/20230929_110616_optional_file_size.py
Show resolved
Hide resolved
jgadling
approved these changes
Sep 29, 2023
robertaboukhalil
deleted the
raboukhalil/CZID-8655-mark-upload-complete-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we commit changes to the DB