Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CZID-8458] Endpoint to validate files and mark them successfully uploaded #62

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

jgadling
Copy link
Collaborator

Right now this does some incredibly-basic validation for fastq files -- @robertaboukhalil I'm all ears on the best way to validate the different file formats we support!

However, it's wired up to be able to add new formats/validators pretty easily so we can extend this over time.

Copy link
Contributor

@robertaboukhalil robertaboukhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

[(db.Entity, model_cls.entity_id == db.Entity.id)], # type: ignore
)
) -> typing.Sequence[E]:
query = get_resource_query(principal, cerbos_client, CerbosAction.VIEW, model_cls)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jgadling jgadling changed the title Endpoint to validate files and mark them successfully uploaded [CZID-8458] Endpoint to validate files and mark them successfully uploaded Sep 21, 2023
@jgadling jgadling merged commit dd3b5fb into main Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants