Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CZID-8457] Create a file - part 1 #61

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

robertaboukhalil
Copy link
Contributor

@robertaboukhalil robertaboukhalil commented Sep 19, 2023

Create a file mutation, creates a signed URL. Will send a part 2 with tests.

entities/api/main.py Outdated Show resolved Hide resolved
@robertaboukhalil robertaboukhalil changed the title [CZID-8457] Upload signed urls [CZID-8457] Create a file - part 1 Sep 21, 2023
@robertaboukhalil robertaboukhalil marked this pull request as ready for review September 21, 2023 22:40
entities/api/files.py Outdated Show resolved Hide resolved
entities/api/files.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jgadling jgadling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the settings vs os.getenv is fixed!

@robertaboukhalil robertaboukhalil merged commit 7c737eb into main Sep 21, 2023
2 checks passed
@robertaboukhalil robertaboukhalil deleted the raboukhalil/CZID-8457-upload-signed-urls branch September 21, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants