Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create database migration to add WGS entities #109

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Create database migration to add WGS entities #109

merged 2 commits into from
Nov 9, 2023

Conversation

j-x-han
Copy link
Contributor

@j-x-han j-x-han commented Nov 9, 2023

Follow up to #106

Ran make alembic-autogenerate to generate the migration script, then ran make alembic-upgrade-head to update db.

I ended up manually dropping the existing tables in the database since there were conflicts with the existing data vs the new required columns getting added.

TODOs for followup PRs:

  • Add factories + update the seed script so we have some dummy data to work with
  • Fix the tests
  • Add a proper DatetimeComparator (only used for Sample.collection_date)

@j-x-han j-x-han merged commit 1e27efd into main Nov 9, 2023
1 of 2 checks passed
@j-x-han j-x-han deleted the j-x-han/wgs-db branch November 9, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertaboukhalil robertaboukhalil robertaboukhalil approved these changes

@jgadling jgadling Awaiting requested review from jgadling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-x-han @robertaboukhalil