feat: Updates to the alignment entity #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
changed the title
jgadling
reviewed
Oct 1, 2024
| return None | ||
| @classmethod | ||
| def get_name_and_path(cls, metadata: dict, name: str, path: str, results: dict[str, str]) -> [str, str, dict]: | ||
| paths = {filname: filname for filname in metadata.get("files", [])} |
Bento007
approved these changes
Oct 1, 2024
| format: OPTIONAL ENUM (IMOD, ARETOMO) | ||
| method_type: OPTIONAL ENUM (fiducial_based, patch_tracking, projection_matching) | ||
| is_portal_standard: OPTIONAL, BOOLEAN (DEFAULT FALSE) | ||
| offset: OPTIONAL |
| @@ -34,7 +36,7 @@ def upgrade_config(data: dict[str, Any]) -> dict[str, Any]: | |||
|
|
|||
|
|
|||
| def has_changes(file, config): | |||
| with open(file, 'r') as file: | |||
There was a problem hiding this comment.
I think our formatters disagree
| @@ -817,7 +817,7 @@ classes: | |||
| offset: | |||
| description: *desc_alignment_offset | |||
| range: AlignmentOffset | |||
| volume_dimesion: | |||
| volume_dimension: | |||
jgadling
approved these changes
Oct 1, 2024
manasaV3
added a commit
that referenced
this pull request
Oct 4, 2024
* Updates to schema and template * Fixing tests * Adding files to alignments metadata * Update the alignment configs method type * Fixing typo * Adding undefined alignment_method_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Description
Changes to the config schema:
is_canonical->is_portal_standardmethod_typeChanges to the configs:
alignment.method_typein the config. It follows the following conditions:S3 Workflows:
get_name_and_pathclass method to the AlignmentImporter. This allows the DestinationFilterFinder to reference an existing Alignment.