feat: update core schema v2 for alignments and mesh #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ingestion_tools/dataset_configs/template.yaml # schema/ingestion_config/v1.0.0/codegen/ingestion_config_models.py
- add enums for alignment types and format
…smith/997-ctf-alignment # Conflicts: # ingestion_tools/dataset_configs/template.yaml # schema/core/v1.1.0/metadata.yaml
# Conflicts: # ingestion_tools/dataset_configs/10003.yaml # ingestion_tools/dataset_configs/10006.yaml # ingestion_tools/dataset_configs/10436.yaml # ingestion_tools/dataset_configs/10439.yaml
jgadling
reviewed
Sep 25, 2024
jgadling
reviewed
Sep 25, 2024
jgadling
reviewed
Sep 25, 2024
| @@ -594,6 +612,9 @@ classes: | |||
| is_visualization_default: | |||
| exact_mappings: | |||
| - cdp-common:annotation_source_file_is_visualization_default | |||
| is_portal_standard: | |||
| exact_mappings: | |||
| - cdp-common:annotation_source_file_is_portal_standard | |||
There was a problem hiding this comment.
We had a discussion about the is_portal_standard field the other day and iirc It's only supposed to be present on Tomogram and Alignment
There was a problem hiding this comment.
remove from v1 and v2
jgadling
requested changes
Sep 25, 2024
jgadling
approved these changes
Sep 26, 2024
manasaV3
approved these changes
Sep 26, 2024
# Conflicts: # ingestion_tools/dataset_configs/10002.yaml # ingestion_tools/dataset_configs/10004.yaml # ingestion_tools/dataset_configs/10008.yaml # ingestion_tools/dataset_configs/10009.yaml # ingestion_tools/dataset_configs/10426.yaml # ingestion_tools/dataset_configs/10436.yaml # ingestion_tools/dataset_configs/10437.yaml # ingestion_tools/dataset_configs/10438.yaml # ingestion_tools/dataset_configs/10439.yaml # ingestion_tools/dataset_configs/deposition_10301.yaml # ingestion_tools/dataset_configs/deposition_10303.yaml # ingestion_tools/dataset_configs/deposition_10304.yaml # ingestion_tools/dataset_configs/deposition_10308.yaml # ingestion_tools/scripts/schema_migration/transform_ingestion_configs.py
# Conflicts: # ingestion_tools/dataset_configs/10000.yaml # ingestion_tools/dataset_configs/10001.yaml # ingestion_tools/dataset_configs/10002.yaml # ingestion_tools/dataset_configs/10003.yaml # ingestion_tools/dataset_configs/10004.yaml # ingestion_tools/dataset_configs/10005.yaml # ingestion_tools/dataset_configs/10006.yaml # ingestion_tools/dataset_configs/10007.yaml # ingestion_tools/dataset_configs/10008.yaml # ingestion_tools/dataset_configs/10009.yaml # ingestion_tools/dataset_configs/10010.yaml # ingestion_tools/dataset_configs/10301.yaml # ingestion_tools/dataset_configs/10436.yaml # ingestion_tools/dataset_configs/10437.yaml # ingestion_tools/dataset_configs/10438.yaml # ingestion_tools/dataset_configs/10439.yaml # ingestion_tools/dataset_configs/deposition_10301.yaml # ingestion_tools/dataset_configs/deposition_10302.yaml # ingestion_tools/dataset_configs/deposition_10303.yaml # ingestion_tools/dataset_configs/deposition_10304.yaml # ingestion_tools/dataset_configs/deposition_10305.yaml # ingestion_tools/dataset_configs/deposition_10308.yaml # ingestion_tools/scripts/schema_migration/migrate_v1_1_0.py # schema/core/v1.1.0/codegen/metadata_materialized.yaml # schema/core/v1.1.0/codegen/metadata_models.py # schema/core/v1.1.0/metadata.yaml # schema/ingestion_config/v1.0.0/codegen/ingestion_config_models.py # schema/ingestion_config/v1.0.0/codegen/ingestion_config_models.schema.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update core schema v2 to match the changes in for v1 from chanzuckerberg/cryoet-data-portal#997