-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set-up docsite #99
Conversation
api/python/Makefile
Outdated
@@ -4,6 +4,10 @@ install: package-data | |||
install-dev: package-data | |||
pip install -e .[test] | |||
|
|||
install-docs: | |||
pip install . | |||
pip install pdoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this to pyproject.yaml
[project.optional-dependencies]
test = ["pytest"]
docs = ["pydoc"]
Then change this make recipe to
install-docs:
pip install .[docs]
I made a sphinx version of the docs, and it was a lot more work and still doesn't look as good as the pdoc version. If we host on readthedocs we get the versioning for free, but that requires a subscription. Sphinx doesn't support it out of the box and will require additional configuration to work. For now I think this is good enough. We should host the latest at least and can add instructions that the users can follow to generate docs for older versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure where the docsite homepage description is being set, but there is a typo:
"CellxGene Ontology Guide is a filtered and currated collection of ontological metadata from different public sources"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data submodule page is empty on the docsite as well, we should probably find a way to not include it since its an internal directory anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird non-definition for this attribute here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-definitions of attributes here as well https://chanzuckerberg.github.io/cellxgene-ontology-guide/cellxgene_ontology_guide/supported_versions.html#CXGSchema.supported_ontologies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, just a few things to fix
In a separate ticket, we should document (in the repo, not docsite) the release process + changelog best practices for contributors
# Conflicts: # .github/workflows/push-tests.yml # api/python/pyproject.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 83.73% 83.89% +0.15%
==========================================
Files 18 18
Lines 916 925 +9
Branches 176 176
==========================================
+ Hits 767 776 +9
Misses 139 139
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🤖 I have created a release *beep* *boop* --- <details><summary>python-api: 0.2.0</summary> ## [0.2.0](python-api-v0.1.2...python-api-v0.2.0) (2024-03-25) ### Features * add function to fetch curated ontology term lists ([#141](#141)) ([5c7db62](5c7db62)) * set-up docsite ([#99](#99)) ([b7591bc](b7591bc)) ### Misc * enable code coverage ([#143](#143)) ([c52c436](c52c436)) * use trusted publisher to publish pypi package. ([#137](#137)) ([5fc917b](5fc917b)) ### BugFixes * make constant.py private ([46d04a4](46d04a4)) * typos ([76ae9fa](76ae9fa)) </details> <details><summary>ontology-assets: 0.2.0</summary> ## [0.2.0](ontology-assets-v0.1.0...ontology-assets-v0.2.0) (2024-03-25) ### Features * add function to fetch curated ontology term lists ([#141](#141)) ([5c7db62](5c7db62)) ### Misc * update ontology decendant mappings ([#142](#142)) ([fb23618](fb23618)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Reason for Change
Changes
Testing steps
Notes for Reviewer