Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set-up docsite #99

Merged
merged 25 commits into from
Mar 25, 2024
Merged

feat: set-up docsite #99

merged 25 commits into from
Mar 25, 2024

Conversation

nayib-jose-gloria
Copy link
Collaborator

@nayib-jose-gloria nayib-jose-gloria commented Mar 8, 2024

Reason for Change

Changes

  • renamed constants.py to _constants.py to not expose constants in API docs
  • use pdoc to generate documentation based on docstring
  • add gha to deploy docsite changes on merge to main

Testing steps

  • update GHA to test that docsite won't break as a 'push test', but only deploy new site on merge to main

Notes for Reviewer

@@ -4,6 +4,10 @@ install: package-data
install-dev: package-data
pip install -e .[test]

install-docs:
pip install .
pip install pdoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this to pyproject.yaml

[project.optional-dependencies]
test = ["pytest"]
docs = ["pydoc"]

Then change this make recipe to

install-docs:
	pip install .[docs]

@Bento007
Copy link
Collaborator

I made a sphinx version of the docs, and it was a lot more work and still doesn't look as good as the pdoc version. If we host on readthedocs we get the versioning for free, but that requires a subscription. Sphinx doesn't support it out of the box and will require additional configuration to work. For now I think this is good enough. We should host the latest at least and can add instructions that the users can follow to generate docs for older versions.

@Bento007 Bento007 marked this pull request as ready for review March 20, 2024 17:56
@Bento007 Bento007 self-requested a review March 22, 2024 19:33
Copy link
Collaborator Author

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure where the docsite homepage description is being set, but there is a typo:

"CellxGene Ontology Guide is a filtered and currated collection of ontological metadata from different public sources"

Copy link
Collaborator Author

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data submodule page is empty on the docsite as well, we should probably find a way to not include it since its an internal directory anyway

Copy link
Collaborator Author

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, just a few things to fix

In a separate ticket, we should document (in the repo, not docsite) the release process + changelog best practices for contributors

# Conflicts:
#	.github/workflows/push-tests.yml
#	api/python/pyproject.toml
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (c52c436) to head (4b0eaf6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   83.73%   83.89%   +0.15%     
==========================================
  Files          18       18              
  Lines         916      925       +9     
  Branches      176      176              
==========================================
+ Hits          767      776       +9     
  Misses        139      139              
  Partials       10       10              
Flag Coverage Δ
unittests 83.89% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bento007 Bento007 enabled auto-merge (squash) March 25, 2024 18:12
Copy link
Collaborator Author

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bento007 Bento007 disabled auto-merge March 25, 2024 18:23
@Bento007 Bento007 merged commit b7591bc into main Mar 25, 2024
8 checks passed
@Bento007 Bento007 deleted the nayib/docsite branch March 25, 2024 18:23
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Bento007 pushed a commit that referenced this pull request Mar 25, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>python-api: 0.2.0</summary>

##
[0.2.0](python-api-v0.1.2...python-api-v0.2.0)
(2024-03-25)


### Features

* add function to fetch curated ontology term lists
([#141](#141))
([5c7db62](5c7db62))
* set-up docsite
([#99](#99))
([b7591bc](b7591bc))


### Misc

* enable code coverage
([#143](#143))
([c52c436](c52c436))
* use trusted publisher to publish pypi package.
([#137](#137))
([5fc917b](5fc917b))


### BugFixes

* make constant.py private
([46d04a4](46d04a4))
* typos
([76ae9fa](76ae9fa))
</details>

<details><summary>ontology-assets: 0.2.0</summary>

##
[0.2.0](ontology-assets-v0.1.0...ontology-assets-v0.2.0)
(2024-03-25)


### Features

* add function to fetch curated ontology term lists
([#141](#141))
([5c7db62](5c7db62))


### Misc

* update ontology decendant mappings
([#142](#142))
([fb23618](fb23618))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants