Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): add testing for ontology-builder #30

Merged
merged 6 commits into from
Feb 14, 2024
Merged

feat(testing): add testing for ontology-builder #30

merged 6 commits into from
Feb 14, 2024

Conversation

Bento007
Copy link
Collaborator

@Bento007 Bento007 commented Feb 14, 2024 •
edited
Loading

Reason for Change

Changes

  • GHA to run on push
  • add make recipe to run tests
  • update readme with instructions to run
  • update mypy precommit to ignore test files
  • add requirements for testing
  • add pyproject.toml to configure pytest test
  • add unit-test for all_ontology_generator.py

Testing steps

  • adding initial tests.

Notes for Reviewer

nayib-jose-gloria
nayib-jose-gloria approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, looks good

@Bento007 Bento007 merged commit e087eca into main Feb 14, 2024
2 checks passed
@Bento007 Bento007 deleted the tsmith/tests branch February 14, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayib-jose-gloria nayib-jose-gloria nayib-jose-gloria approved these changes

Assignees

@nayib-jose-gloria nayib-jose-gloria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bento007 @nayib-jose-gloria